From 30d1eb08b42e9eeb76037fdc8613610878ba1092 Mon Sep 17 00:00:00 2001 From: Sascha Hauer Date: Fri, 23 Feb 2024 09:45:44 +0100 Subject: [PATCH] signing.bbclass: fix wrong function name The function signing_import_pubkey_from_pem is defined twice, one of them should really be named signing_import_pubkey_from_der. Fix this and while at it fix some argument names in the comments above the functions as well. Reported-by: Miklos Toth Fixes: 4a6ac691f ("add signing.bbclass as infrastructure for build artifact signing") Signed-off-by: Sascha Hauer Signed-off-by: Khem Raj --- meta-oe/classes/signing.bbclass | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meta-oe/classes/signing.bbclass b/meta-oe/classes/signing.bbclass index 553d74e283..ec076d9685 100644 --- a/meta-oe/classes/signing.bbclass +++ b/meta-oe/classes/signing.bbclass @@ -142,10 +142,10 @@ signing_import_cert_from_pem() { signing_pkcs11_tool --type cert --write-object /proc/self/fd/0 --label "${role}" } -# signing_import_pubkey_from_der +# signing_import_pubkey_from_der # # Import a public key from DER file to a role. To be used with SoftHSM. -signing_import_pubkey_from_pem() { +signing_import_pubkey_from_der() { local role="${1}" local der="${2}" @@ -171,7 +171,7 @@ signing_import_pubkey_from_pem() { signing_pkcs11_tool --type pubkey --write-object /proc/self/fd/0 --label "${role}" } -# signing_import_privkey_from_der +# signing_import_privkey_from_der # # Import a private key from DER file to a role. To be used with SoftHSM. signing_import_privkey_from_der() {