Set ac_cv_prog_cc_c23=no to prevent autoconf from detecting C23
compiler support, avoiding potential build failures as the package
is not yet fully ported to support C23 standard.
Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
The riscv64 is now in COMPATIBLE_HOST of valgrind.
The armv4/armv5/armv6 are not in COMPATIBLE_HOST of valgrind.
Update the settings accordingly.
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
The rsyslog recipe incorrectly passes the permission mode as a
positional argument to install -d. In this form, the value is treated
as a directory name rather than as a mode, which will create an additional directory
and may result in unexpected behavior during installation.
Use the -m option to ensure the directory is created with the intended
permissions.
Signed-off-by: Mikhail Anikin <mikhail.anikin@solid-run.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
This upgrade is mostly bug fixes according to:
https://github.com/rsyslog/librelp/blob/master/ChangeLog
but there is one new API:
add ability to communicate source port back to caller
Drop the backported patch:
0001-Fix-function-inline-errors-in-debug-optimization-Og.patch
Drop patches merged upstream:
0001-tests-Include-missing-sys-time.h.patch
-> 8c96857 tests: Include missing sys/time.h
0001-relp-fix-build-against-upcoming-gcc-14-Werror-calloc.patch
-> baf992f relp: fix build against upcoming `gcc-14` ...
0001-tests-Fix-callback-prototype.patch
-> a4cb0bd tests: Fix callback prototype
0001-tcp-fix-some-compiler-warnings-with-enable-tls-opens.patch
-> 6e9b27f tcp: fix some compiler warnings with enable-tls-openssl
Ptest for qemux86-64, qemuarm64 with glibc and musl:
TOTAL: 30
PASS: 27
SKIP: 3
XFAIL: 0
FAIL: 0
XPASS: 0
ERROR: 0
Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Full Changelog:
https://github.com/rsyslog/rsyslog/blob/v8-stable/ChangeLog
Avoid buildpath error:
QA Issue: File /usr/lib/rsyslog/ptest/tests/.deps/liboverride_getaddrinfo_la-override_getaddrinfo.Plo
These .deps directories are created at configure time and mainly used
in an interactive development environment. Remove test/.deps to eliminate
the error.
Drop: use-pkgconfig-to-check-libgcrypt.patch
since it's implemented upstream by:
85e03c0e8 Replace libgcrypt-config with pkg-config
8ba35bf6c Add missing libraries to pkg-config call
as per: https://github.com/rsyslog/rsyslog/pull/5406/commits
For musl, drop: 0001-Include-sys-time-h.patch
which oddly doesn't seem to be required to build any of: qemux86-64, qemuarm64,
and qemuarm.
Rebase other patches as needed.
ptest results for qemux86-64/kvm with extra FS space and 2 GB RAM:
Version | Total | Passed | Failed | Skipped
8.2506 | 485 | 479 | 0 | 6
8.2510 | 497 | 491 | 0 | 6
rsyslog works when built with musl but there are lots of ptest failures:
Version | Total | Passed | Failed | Skipped
8.2506 | 485 | 306 | 172 | 7
8.2510 | 497 | 310 | 180 | 7
Note that with this update the results are similarily bad. If someone is
interested and has time, they can work on improving the musl ptest results.
Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Details: https://nvd.nist.gov/vuln/detail/CVE-2015-3243
The issue is about file permissions: by default rsyslog creates world-readable
files. In case a log message contains some sensitive information, then that's
exposed to every user on the system.
However the rsyslog.conf file that is shipped with the recipe solves it: it
already sets non-world-readable default permissions on all files, so this
vulnerability is fixed in the default OE recipe.
See also this package in OpenSuse[1], where it is solved the same way.
[1]: https://build.opensuse.org/requests/619439/changes (rsyslog.conf.in)
Signed-off-by: Gyorgy Sarvari <skandigraun@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Please see
https://git.yoctoproject.org/poky/commit/?id=4dd321f8b83afecd962393101b2a6861275b5265
for what changes are needed, and sed commands that can be used to make them en masse.
I've verified that bitbake -c patch world works with these, but did not run a world
build; the majority of recipes shouldn't need further fixups, but if there are
some that still fall out, they can be fixed in followups.
Signed-off-by: Alexander Kanavin <alex@linutronix.de>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Update rsyslog from 8.2408.0 to 8.2502.0.
Full Changelog:
https://github.com/rsyslog/rsyslog/blob/v8-stable/ChangeLog
ptest results did not change from 2408:
TOTAL: 469
PASS: 464
SKIP: 5
Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Add a sed substitution for ${PTEST_PATH}/${TESTDIR}/Makefile that
transforms
LOG_DRIVER = $(SHELL) $(top_srcdir)/test-driver
SH_LOG_DRIVER = $(SHELL) $(top_srcdir)/test-driver
to
LOG_DRIVER = $(SHELL) $(top_builddir)/test-driver
SH_LOG_DRIVER = $(SHELL) $(top_builddir)/test-driver
which is where the test-driver script can be found when installed.
The addition of this substition makes ptests work with or without an
automake patch in OE-Core that does the same thing.
Relates to [YOCTO #15635]
Signed-off-by: Ola x Nilsson <olani@axis.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Add a sed substitution for ${PTEST_PATH}/${TESTDIR}/Makefile that
transforms
SH_LOG_DRIVER = $(SHELL) $(top_srcdir)/test-driver
to
SH_LOG_DRIVER = $(SHELL) $(top_builddir)/test-driver
which is where the test-driver script can be found when installed.
The addition of this substition makes ptests work with or without an
automake patch in OE-Core that does the same thing.
Relates to [YOCTO #15635]
Signed-off-by: Ola x Nilsson <olani@axis.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Build checks for this during configure but the test is a runtime
test, which does not work when cross-compiling, therefore
prescribe this by caching it for architecture/compiler options
where it will work ok.
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Changelog:
============
- omkafka enhance: write Kafka log with level ERROR or higher into errorfile
- net subsusytem bugfix: some config statemens were not accepted
- new "ossl" crypto provider
- imtcp: improve connection error messages
0001-tests-disable-the-check-for-inotify.patch
use-pkgconfig-to-check-libgcrypt.patch
refreshed for 8.2408.0
Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Fix the UNKNOWN_BROKEN status from running
devtool check-upgrade-status.
The next version of the package can be found from upstream
sources by changing existing UPSTREAM_CHECK_URI.
Signed-off-by: Alexandre Truong <alexandre.truong@smile.fr>
Reviewed-by: Yoann Congal <yoann.congal@smile.fr>
Replace references of WORKDIR with UNPACKDIR where it makes sense to do
so in preparation for changing the default value of UNPACKDIR.
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Change the PACKAGECONFIG[systemd] that wrapped --with-systemdsystemunitdir
to use the new --enable-libsystemd option:
acb62dfda remove systemd embedded code, use library instead
The bug related to using libcap-ng has beeen fixed:
030e047fd0
so use that library by default now to allow rsyslog to run with fewer privileges.
PTest results: sysvinit, systemd
TOTAL: 462, 462
PASS: 457, 459
SKIP: 5, 3
XFAIL: 0, 0
FAIL: 0, 0
XPASS: 0, 0
ERROR: 0, 0
Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
gnutls is not enabled in librelp and therefore tests fail becasue it
uses openssl but rsyslog uses gnutls,
FAIL: sndrcv_relp_tls_prio.sh
therefore default to using openssl
for both the packages. gnutls can be enabled for both via bbappends but
its not default anymore.
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Cc: Nicolas Marguet <nicolas.marguet@windriver.com>
valgrind is not available on all arches e.g. riscv so enable it
conditionally
Enable openSSL TLS by default and add option to enable gnuTLS
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Use internal test from librelp project as ptest.
This work is largely inspired on the rsyslog ptest implementation,
which copies the automake-based tests/Makefile to the target and runs
'make check-TESTS'. sed is used to fix a few Makefile paths or
env-vars so 'make' can run on the target.
Tested on qemux86_64 and qemuarm64:
==========================================
librelp 1.11.0: tests/test-suite.log
==========================================
TOTAL: 30
PASS: 27
SKIP: 3
XFAIL: 0
FAIL: 0
XPASS: 0
ERROR: 0
The 3 skipped tests are either self-identified as “not do anything
really useful” or may need to port libtool to the target.
Signed-off-by: Nicolas Marguet <nicolas.marguet@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Compiler does not inline any functions when using debug optimization (-Og).
Hence, remove -Winline flag when compiling with debug optimization.
Backport upstream fix: https://github.com/rsyslog/librelp/pull/258
Remove previous local fix: https://github.com/rsyslog/librelp/issues/256
Signed-off-by: Nicolas Marguet <nicolas.marguet@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
With DEBUG_BUILD = "1", the following error occurs:
src/relpsess.c:95:1: error:
inlining failed in call to 'relpSessFreePermittedPeers': function not considered for inlining [-Werror=inline]
so use the compiler flag '-Wno-error=inline' for DEBUG_OPTIMIZATION only.
Tracked by upstream bug: https://github.com/rsyslog/librelp/issues/256
but it's looking like a toolchain bug.
Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Add PACKAGECONFIG to enable dropping capabilities but leave it as disabled
to follow upstream and avoid a systemd issue described below.
rsyslog-8.2302 added a configure option to drop capabilities from
full to:
chown, dac_override, setgid, setuid, setpcap, net_bind_service,
net_admin, ipc_lock, sys_chroot, sys_admin, sys_resource, lease,
syslog, block_suspend
This works fine and passes ptests with sysvinit however
there is a bug when using systemd that breaks some tests:
https://github.com/rsyslog/rsyslog/issues/5091
Therefore only add a non-default PACKAGECONFIG option in keeping
with the rsyslog upstream.
One can install libcap-ng-bin to run pscap to see the capabilities.
Without this option the ptest result with systemd as init is:
Version | Passed | Failed | Skipped
8.2302 | 473 | 0 | 3
Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Changelog:
===========
- code cleanup
During the initial librelp implementation it was thought about an
auto-retry feature (whatever that means). Variable bAutoRetry was
created to control that behaviour. It's default was 0 (inactive).
Some code has been written to evaluate that variable and act
accordingly. However, no setter method for this variable was
created and it was also nowhere changed from the default value
of zero. As such, the code activated by it was never used.
This patch now removes both the variable and the few code lines
accessing it. This will have no effect, as the code was never
used.
- testbench: Fix commands in some openssl tests
Those commands were not correctly handeled on AIX, now they are.
- AIX: Changed ERRNO handling after connect in tcp.c
- AIX: Add handling for other ERRNO codes in tcp.c
- bugfix/TCP: relpTcpGetRtryDirection onyl needs to check direction if SSL is active.
- AIX: in relpTcpRcv we need to set RETRY_recv if errno is 0
On AIX 10.x, when a recv call fails with len -1 and errno 0
we can still go into relpTCP_RETRY_recv mode. Testbench on
rsyslog side appears to be finally working with this fix.
On AIX 10.x, same problem as above appear to happen with
connect() as well not setting errno to EINPROGRESS on failure.
rsyslog ptcp driver does not check errno value at all, which is
why we did not have this problem on AIX with rsyslog.
Reduce test message count in receiver-abort.sh to 50000,
because otherwise the test can timeout on very slow machines.
- openssl: fix openssl exit code avoid double free of ctx
When more than one librelp instance are used in the same process,
and the relpTcpExitTLS call was called a second time, the process
could freeze due a double free (See SSL_CTX_free call).
Thanks to David GOUARIN <david.gouarin@thalesgroup.com> for the
discovery and initial fix.
Also added an openssl instance counter to avoid freeing the SSL library
which could be still in use by another librelp instance
in the same process.
- librelp hardening: Fix multiple minor issues causing debugging trouble
- avoid invalid dbgprint calls
- avoid double free in relpTcpDestruct (if called twice).
- add debug output into relpTcpRcv
- OpenSSL: fix depreacted API issues for OpenSSL 3.x
- OpenSSL error strings are loaded automatically now
- Adapted Debug Callback for 3.x
- bugfix: compatiblity problem with openssl 1.1
There were undefined reference to CRYPTO_set_id_callback if system
use openssl 1.1, which lead to load and/or other erros.
- bugfix: Forward return code from relpEngineSetTLSLib to relpEngineSetTLSLibName
Previous situation: In case librelp is compiled without openssl
support but openssl is requested from the user side, then librelp
silently switches to the default tls driver(gnutls).
- bugfix: make relpEngineSetTLSLib debug safe
In case pThis == NULL condition is true at line
- bugfix: warnings reported by coverity scan
- testbench: Added compatiblity to run on AIX
- removed long options from receive send utilities (Not supported on AIX).
- added checks for existing commands in some tests.
- added msleep utility from rsyslog (sleep, timeout etc. not supported on AIX).
- github workflow: Disabled some unrelated tests from rsyslog testbench
- gnutls drvr bugfix: library called exit() under some circumstances
When relpTcpRcv ran into an error, it could call exit() and thus
terminate the calling process.
Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Package changes mainly include performance improvements to
template processing/json, imptcp, additional functions to openssl, bug fixes and additional/updated tests:
https://github.com/rsyslog/rsyslog/blob/master/ChangeLog
ptest results for qemux86-64 with kvm and increasing filesystem
space to 5GB using IMAGE_ROOTFS_EXTRA_SPACE :
Version | Passed | Failed | Skipped
8.2206 | 465 | 0 | 5
8.2208 | 465 | 1 | 5
The test imfile-statefile-delete.sh is failed because state file
still exists while it should be deleted. Already reported to
rsyslog developers.
Signed-off-by: Zheng Qiu <zheng.qiu@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Package changes are mostly bug fixes, and additions to modules/tests:
https://github.com/rsyslog/rsyslog/blob/master/ChangeLog
I removed the md5sum line since it's obsolete.
ptest results for qemux86-64 with kvm and a timeout
of 1000 seconds to allow stress tests to complete:
Version | Passed | Failed | Skipped
8.2106 | 428 | 0 | 5
8.2202 | 456 | 0 | 5
Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
This patch updates SRC_URIs using git to include branch=master if no branch is set
and also to use protocol=https for github urls as generated by the conversion script
in OE-Core.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
This is the result of automated script (0.9.1) conversion:
oe-core/scripts/contrib/convert-overrides.py .
converting the metadata to use ":" as the override character instead of "_".
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Run test as non-root 'tester'.
Add more rdepends for ptest.
Introduce a patch to skip checking for a libc header:
sys/inotify
Python scripts no longer called with ./script.
Remove the need to add the correct shebang.
Ptest results:
8.2102.0
===============
TOTAL: 424
PASS: 417
SKIP: 5
XFAIL: 0
FAIL: 2
XPASS: 0
ERROR: 0
Remaining failure related to relp:
* imrelp-tls-cfgcmd
* sndrcv_relp_tls-cfgcmd
the test expects an error "relp connect failed with return 10031",
but the connection seems to be established and working.
Signed-off-by: Yi Fan Yu <yifan.yu@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
