mirror of
git://git.openembedded.org/meta-openembedded
synced 2026-10-02 16:55:11 +00:00
4f78732be2
Upstream-Status: Backport from https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=3f7342671341a7a137f2d8b06ab3461cdb0e1d88 Signed-off-by: Hitendra Prajapati <hprajapati@mvista.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
49 lines
1.9 KiB
Diff
49 lines
1.9 KiB
Diff
From 3f7342671341a7a137f2d8b06ab3461cdb0e1d88 Mon Sep 17 00:00:00 2001
|
|
From: Michael Paquier <michael@paquier.xyz>
|
|
Date: Mon, 6 Feb 2023 11:20:31 +0900
|
|
Subject: [PATCH] Properly NULL-terminate GSS receive buffer on error packet
|
|
reception
|
|
|
|
pqsecure_open_gss() includes a code path handling error messages with
|
|
v2-style protocol messages coming from the server. The client-side
|
|
buffer holding the error message does not force a NULL-termination, with
|
|
the data of the server getting copied to the errorMessage of the
|
|
connection. Hence, it would be possible for a server to send an
|
|
unterminated string and copy arbitrary bytes in the buffer receiving the
|
|
error message in the client, opening the door to a crash or even data
|
|
exposure.
|
|
|
|
As at this stage of the authentication process the exchange has not been
|
|
completed yet, this could be abused by an attacker without Kerberos
|
|
credentials. Clients that have a valid kerberos cache are vulnerable as
|
|
libpq opportunistically requests for it except if gssencmode is
|
|
disabled.
|
|
|
|
Author: Jacob Champion
|
|
Backpatch-through: 12
|
|
Security: CVE-2022-41862
|
|
|
|
CVE: CVE-2022-41862
|
|
Upstream-Status: Backport [https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=3f7342671341a7a137f2d8b06ab3461cdb0e1d88]
|
|
Signed-off-by: Hitendra Prajapati <hprajapati@mvista.com>
|
|
---
|
|
src/interfaces/libpq/fe-secure-gssapi.c | 2 ++
|
|
1 file changed, 2 insertions(+)
|
|
|
|
diff --git a/src/interfaces/libpq/fe-secure-gssapi.c b/src/interfaces/libpq/fe-secure-gssapi.c
|
|
index 7b5e383..aef201b 100644
|
|
--- a/src/interfaces/libpq/fe-secure-gssapi.c
|
|
+++ b/src/interfaces/libpq/fe-secure-gssapi.c
|
|
@@ -578,6 +578,8 @@ pqsecure_open_gss(PGconn *conn)
|
|
|
|
PqGSSRecvLength += ret;
|
|
|
|
+ Assert(PqGSSRecvLength < PQ_GSS_RECV_BUFFER_SIZE);
|
|
+ PqGSSRecvBuffer[PqGSSRecvLength] = '\0';
|
|
printfPQExpBuffer(&conn->errorMessage, "%s\n", PqGSSRecvBuffer + 1);
|
|
|
|
return PGRES_POLLING_FAILED;
|
|
--
|
|
2.25.1
|
|
|