helium-3rd-party/poky
1
0
Fork 0
mirror of git://git.yoctoproject.org/poky synced 2026-08-13 08:56:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

bluez: Fix invalid-pp-token warning found with clang

Browse Source 
We add FIRMWARE_DIR via CFLAGS using escapes for string and clang
option parser flags it

<command line>:4:23: warning: missing terminating '"' character [-Winvalid-pp-token]
    4 | #define FIRMWARE_DIR \"/usr/lib/firmware\"
      |                       ^

emitting this warning during configure means some tests fail wrongly. e.g.
test for enable -fPIC -DPIC, which results in textrels in libbbluetooth.so

Pass the string definition using single quotes to avoid the shell
"eating" the quotes and other characters

This works well across gcc and clang

(From OE-Core rev: 23a87f27b1837bd35bea356f0a10816fb35826f2)

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Khem Raj 2025-07-23 22:57:01 -07:00 committed by Richard Purdie
parent 7e36ded417
commit 1f9f818787
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
meta/recipes-connectivity/bluez5/bluez5.inc
View File

@ -81,7 +81,7 @@ EXTRA_OECONF = "\
--without-zsh-completion-dir \
"
CFLAGS += "-DFIRMWARE_DIR=\\"${nonarch_base_libdir}/firmware\\""
CFLAGS += "-DFIRMWARE_DIR='"${nonarch_base_libdir}/firmware"'"
# bluez5 builds a large number of useful utilities but does not
# install them. Specify which ones we want put into ${PN}-noinst-tools.